Disallow snapshot deletion while a v2 snapshot is in progress #16430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Bafna <[email protected]>
|
❌ Gradle check result for 2907d52: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Gaurav Bafna <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16430 +/- ##
============================================
- Coverage 72.11% 71.97% -0.15%
+ Complexity 65044 64973 -71
============================================
Files 5313 5313
Lines 303287 303296 +9
Branches 43883 43884 +1
============================================
- Hits 218729 218300 -429
- Misses 66593 67080 +487
+ Partials 17965 17916 -49 ☔ View full report in Codecov by Sentry. |
sachinpkale
approved these changes
Oct 23, 2024
|
Changes are covered as part of integ tests, bypassing CodeCov |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
--------- Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit bb1359f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Oct 23, 2024
#16450) --------- (cherry picked from commit bb1359f) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we were accepting deletes while a create/clone v2 operation was going on . Post create/clone, we did a
runNextQueuedOperationto run the queued operation . However ,runNextQueuedOperationcreates a pending task ofNORMALpriority . In cases where pending tasks are high , this will starve. Meanwhile , the new create/clone v2 snapshots also can't start as it won't get the repo lock .To solve for this, we are not accepting deletes when a create/clone v2 operation is going on and have now removed the
runNextQueuedOperation.Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.